Skip to content

OCPBUGS-72257: feat(vgmanager): improve encrypted devices deletion #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qJkee merged 1 commit into from
Jan 12, 2026
Merged

OCPBUGS-72257: feat(vgmanager): improve encrypted devices deletion #1912

qJkee merged 1 commit into from
Jan 12, 2026

Conversation

@qJkee
Copy link
Contributor

@qJkee qJkee commented Jan 9, 2026

Improve deletion logic for encrypted devices as user provided device name and actual device name on host usually doesnt match

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 9, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2026

@qJkee: This pull request references Jira Issue OCPBUGS-72257, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Improve deletion logic for encrypted devices as user provided device name and actual device name on host usually doesnt match

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 9, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.17%. Comparing base (c070ca9) to head (79df3d0).
⚠️ Report is 84 commits behind head on main.

Files with missing lines Patch % Lines
internal/controllers/vgmanager/controller.go 37.50% 3 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1912      +/-   ##
==========================================
- Coverage   48.69%   48.17%   -0.53%     
==========================================
  Files          52       52              
  Lines        3709     3716       +7     
==========================================
- Hits         1806     1790      -16     
- Misses       1753     1772      +19     
- Partials      150      154       +4
Files with missing lines Coverage Δ
internal/controllers/vgmanager/controller.go 66.38% <37.50%> (-0.36%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2026
@qJkee
Copy link
Contributor Author

qJkee commented Jan 9, 2026

/retest

@suleymanakbas91
Copy link
Contributor

suleymanakbas91 commented Jan 9, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2026
@qJkee
Copy link
Contributor Author

qJkee commented Jan 12, 2026

/retest

@qJkee
feat(vgmanager): improve encrypted devices deletion
79df3d0 
Improve deletion logic for encrypted devices as user provided
device name and actual device name on host usually doesnt match
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2026

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@qJkee
Copy link
Contributor Author

qJkee commented Jan 12, 2026

/retest

@suleymanakbas91
Copy link
Contributor

suleymanakbas91 commented Jan 12, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2026
@qJkee qJkee merged commit 6d1ec41 into openshift:main Jan 12, 2026
13 of 14 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 12, 2026

@qJkee: Jira Issue OCPBUGS-72257: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-72257 has been moved to the MODIFIED state.

Details

In response to this:

Improve deletion logic for encrypted devices as user provided device name and actual device name on host usually doesnt match

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qJkee qJkee deleted the OCPBUGS-72257 branch January 13, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaypoulz jaypoulz Awaiting requested review from jaypoulz

@suleymanakbas91 suleymanakbas91 Awaiting requested review from suleymanakbas91

Assignees

@suleymanakbas91 suleymanakbas91

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qJkee @openshift-ci-robot @codecov-commenter @suleymanakbas91